airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] kaxil commented on a change in pull request #3887: [AIRFLOW-3044] Dataflow operators accept templated job_name param
Date Wed, 12 Sep 2018 21:29:59 GMT
kaxil commented on a change in pull request #3887: [AIRFLOW-3044] Dataflow operators accept
templated job_name param
URL: https://github.com/apache/incubator-airflow/pull/3887#discussion_r217194071
 
 

 ##########
 File path: tests/contrib/hooks/test_gcp_dataflow_hook.py
 ##########
 @@ -178,18 +178,18 @@ def poll_resp_error():
 
     def test_valid_dataflow_job_name(self):
         job_name = self.dataflow_hook._build_dataflow_job_name(
-            task_id=TASK_ID, append_job_name=False
+            job_name=JOB_NAME, append_job_name=False
         )
 
-        self.assertEquals(job_name, TASK_ID)
+        self.assertEquals(job_name, JOB_NAME)
 
     def test_fix_underscore_in_task_id(self):
 
 Review comment:
   `test_fix_underscore_in_task_id` -> you might want to rename the name of this method
and its associated test

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message