airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] xnuinside commented on a change in pull request #3880: [AIRFLOW-461] Support autodetected schemas in BigQuery run_load
Date Tue, 11 Sep 2018 13:51:03 GMT
xnuinside commented on a change in pull request #3880: [AIRFLOW-461]  Support autodetected
schemas in BigQuery run_load
URL: https://github.com/apache/incubator-airflow/pull/3880#discussion_r216676844
 
 

 ##########
 File path: airflow/contrib/hooks/bigquery_hook.py
 ##########
 @@ -851,8 +851,9 @@ def run_copy(self,
 
     def run_load(self,
                  destination_project_dataset_table,
 
 Review comment:
   @fokko, Exuse me) I can’t catch how it breaks if there are no changes to old args and
no logic changes. Just for understanding, seems I miss something. About contributing.md -
okay.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message