airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ChengzhiZhao commented on issue #3858: [AIRFLOW-2929] Add get and set for pool class in models
Date Fri, 07 Sep 2018 16:53:05 GMT
ChengzhiZhao commented on issue #3858: [AIRFLOW-2929] Add get and set for pool class in models
URL: https://github.com/apache/incubator-airflow/pull/3858#issuecomment-419500933
 
 
   @feng-tao thanks for reviewing on this, I would need some suggestions here: 
   1. Since this is refactoring changes, the tests/core.py should cover the unit tests for
them, for example,  https://github.com/apache/incubator-airflow/blob/master/tests/core.py#L1493.
Should I add more unit test?
   2. I can remove pool class from api client, but my question is should we continue using
`airflow.api.common.experimental` for pool or have all methods in Pool class like we did for
`Variable`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message