airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ashb commented on a change in pull request #3861: [AIRFLOW-XXX] Fix doc of command line interface
Date Fri, 07 Sep 2018 08:43:27 GMT
ashb commented on a change in pull request #3861: [AIRFLOW-XXX] Fix doc of command line interface
URL: https://github.com/apache/incubator-airflow/pull/3861#discussion_r215887440
 
 

 ##########
 File path: airflow/bin/cli.py
 ##########
 @@ -1457,7 +1457,7 @@ class CLIFactory(object):
         'subdir': Arg(
             ("-sd", "--subdir"),
             "File location or directory from which to look for the dag",
-            default=settings.DAGS_FOLDER),
+            default="[AIRFLOW_HOME]/dags"),
 
 Review comment:
   Unfortunatley changing this default actually changes the value that will be in `args.subdir`
- so this change would break a lot of things.
   
   It might be possible to change the `$AIRFLOW_HOME` when rendering the docs, or to change
the display of this param?
   
   @kaxil How are the docs built when render

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message