airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] Fokko commented on a change in pull request #3852: [AIRFLOW-3018] Fix Minor issues in Documentation
Date Thu, 06 Sep 2018 10:59:31 GMT
Fokko commented on a change in pull request #3852: [AIRFLOW-3018] Fix Minor issues in Documentation
URL: https://github.com/apache/incubator-airflow/pull/3852#discussion_r215582430
 
 

 ##########
 File path: airflow/contrib/operators/dataflow_operator.py
 ##########
 @@ -149,6 +148,25 @@ class DataflowTemplateOperator(BaseOperator):
     """
     Start a Templated Cloud DataFlow batch job. The parameters of the operation
     will be passed to the job.
+
+    :param template: The reference to the DataFlow template.
+    :type template: string
+    :param dataflow_default_options: Map of default job environment options.
+    :type dataflow_default_options: dict
+    :param parameters: Map of job specific parameters for the template.
+    :type parameters: dict
+    :param gcp_conn_id: The connection ID to use connecting to Google Cloud
+    Platform.
 
 Review comment:
   How do we indent? In this docstring there are two ways?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message