airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] XD-DENG commented on a change in pull request #3823: [AIRFLOW-2985] An operator for S3 object copying/deleting
Date Tue, 04 Sep 2018 14:58:48 GMT
XD-DENG commented on a change in pull request #3823: [AIRFLOW-2985] An operator for S3 object
copying/deleting
URL: https://github.com/apache/incubator-airflow/pull/3823#discussion_r214949579
 
 

 ##########
 File path: airflow/hooks/S3_hook.py
 ##########
 @@ -384,3 +384,89 @@ def load_bytes(self,
 
         client = self.get_conn()
         client.upload_fileobj(filelike_buffer, bucket_name, key, ExtraArgs=extra_args)
+
+    def _copy_object(self,
 
 Review comment:
   Sure, I will change this part.
   
   Actually the chance of misusing is low given the argument required are totally different.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message