From commits-return-17134-archive-asf-public=cust-asf.ponee.io@airflow.incubator.apache.org Thu Aug 2 18:49:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D48DA180629 for ; Thu, 2 Aug 2018 18:49:04 +0200 (CEST) Received: (qmail 48843 invoked by uid 500); 2 Aug 2018 16:49:04 -0000 Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.incubator.apache.org Delivered-To: mailing list commits@airflow.incubator.apache.org Received: (qmail 48834 invoked by uid 99); 2 Aug 2018 16:49:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Aug 2018 16:49:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 687DFC1837 for ; Thu, 2 Aug 2018 16:49:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id XjS7OjOMGMi5 for ; Thu, 2 Aug 2018 16:49:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id DB5845F396 for ; Thu, 2 Aug 2018 16:49:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 76B9CE2072 for ; Thu, 2 Aug 2018 16:49:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2BA582775E for ; Thu, 2 Aug 2018 16:49:00 +0000 (UTC) Date: Thu, 2 Aug 2018 16:49:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@airflow.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AIRFLOW-2796) Improve code coverage for utils/helpers.py MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AIRFLOW-2796?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 567056#comment-16567056 ]=20 ASF GitHub Bot commented on AIRFLOW-2796: ----------------------------------------- Noremac201 opened a new pull request #3686: [AIRFLOW-2796] Expand code cove= rage for utils/helpers.py URL: https://github.com/apache/incubator-airflow/pull/3686 =20 =20 Make sure you have checked _all_ steps below. =20 ### Jira =20 - [x] My PR addresses the following [Airflow Jira](https://issues.apache= .org/jira/browse/AIRFLOW/) issues and references them in the PR title. For = example, "\[AIRFLOW-XXX\] My Airflow PR" - https://issues.apache.org/jira/browse/AIRFLOW-2796 =20 ### Description =20 - [x] Here are some details about my PR, including screenshots of any UI= changes: =20 Add more tests for utils/helpers.py =20 ### Tests =20 - [x] My PR adds the following unit tests __OR__ does not need testing f= or this extremely good reason: =20 -`tests/utils/test_helpers.py` =20 ### Commits =20 - [x] My commits all reference Jira issues in their subject lines, and I= have squashed multiple commits if they address the same issue. In addition= , my commits follow the guidelines from "[How to write a good git commit me= ssage](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue refer= ence) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" =20 ### Code Quality =20 - [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff` =20 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > Improve code coverage for utils/helpers.py > ------------------------------------------ > > Key: AIRFLOW-2796 > URL: https://issues.apache.org/jira/browse/AIRFLOW-2796 > Project: Apache Airflow > Issue Type: Bug > Reporter: Andy Cooper > Priority: Trivial > > Improve code coverage by adding tests for=C2=A0 > * is_container > * is_in > * as_tuple -- This message was sent by Atlassian JIRA (v7.6.3#76005)