From commits-return-19031-archive-asf-public=cust-asf.ponee.io@airflow.incubator.apache.org Fri Aug 24 00:03:21 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8BB32180677 for ; Fri, 24 Aug 2018 00:03:21 +0200 (CEST) Received: (qmail 61608 invoked by uid 500); 23 Aug 2018 22:03:20 -0000 Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.incubator.apache.org Delivered-To: mailing list commits@airflow.incubator.apache.org Received: (qmail 61599 invoked by uid 99); 23 Aug 2018 22:03:20 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Aug 2018 22:03:20 +0000 From: GitBox To: commits@airflow.apache.org Subject: [GitHub] dimberman commented on a change in pull request #3782: [AIRFLOW-2936] Use official Python images as base image for Docker Message-ID: <153506180015.2535.14793059567593302853.gitbox@gitbox.apache.org> Date: Thu, 23 Aug 2018 22:03:20 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit dimberman commented on a change in pull request #3782: [AIRFLOW-2936] Use official Python images as base image for Docker URL: https://github.com/apache/incubator-airflow/pull/3782#discussion_r212471258 ########## File path: scripts/ci/kubernetes/docker/airflow-init.sh ########## @@ -17,9 +17,10 @@ # specific language governing permissions and limitations * # under the License. -cd /usr/local/lib/python2.7/dist-packages/airflow && \ -cp -R example_dags/* /root/airflow/dags/ && \ +set -e + +cd /usr/local/lib/python3.7/site-packages/airflow/ && \ +cp -R example_dags/* /home/airflow/dags/ && \ airflow initdb && \ alembic upgrade heads && \ -(airflow create_user -u airflow -l airflow -f jon -e airflow@apache.org -r Admin -p airflow || true) && \ -echo "retrieved from mount" > /root/test_volume/test.txt Review comment: Why did you remove this line? Isn't this necessary for the volume mounting tests? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services