From commits-return-18897-archive-asf-public=cust-asf.ponee.io@airflow.incubator.apache.org Wed Aug 22 18:21:10 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0FC0F180677 for ; Wed, 22 Aug 2018 18:21:09 +0200 (CEST) Received: (qmail 9965 invoked by uid 500); 22 Aug 2018 16:21:04 -0000 Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.incubator.apache.org Delivered-To: mailing list commits@airflow.incubator.apache.org Received: (qmail 9823 invoked by uid 99); 22 Aug 2018 16:21:04 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Aug 2018 16:21:04 +0000 From: GitBox To: commits@airflow.apache.org Subject: [GitHub] jpds opened a new pull request #3774: [AIRFLOW-2920] Added downward API metadata to Kubernetes pods Message-ID: <153495486358.31990.1841555365737898016.gitbox@gitbox.apache.org> Date: Wed, 22 Aug 2018 16:21:03 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit jpds opened a new pull request #3774: [AIRFLOW-2920] Added downward API metadata to Kubernetes pods URL: https://github.com/apache/incubator-airflow/pull/3774 ### Jira - [X] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR" - https://issues.apache.org/jira/browse/AIRFLOW-2920 ### Description This adds https://github.com/kubernetes/kubernetes/blob/release-1.0/docs/user-guide/downward-api.md metadata to pods spun up by the Kubernetes executor. This allows one to then dynamically specify a namespace in the DAG task definition with: ``` task1 = KubernetesPodOperator( namespace=os.getenv('POD_NAMESPACE'), ... ``` Thus allowing multiple Kubernetes deployments to use the same Docker image. ### Tests - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: There does not appear to be tests for the manifest the Kubernetes executor generates. ### Commits - [X] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": ### Documentation - [ ] In case of new functionality, my PR adds documentation that describes how to use it. ### Code Quality - [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff` @dimberman ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services