From commits-return-17620-archive-asf-public=cust-asf.ponee.io@airflow.incubator.apache.org Tue Aug 7 22:40:54 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2ADE5180657 for ; Tue, 7 Aug 2018 22:40:54 +0200 (CEST) Received: (qmail 52227 invoked by uid 500); 7 Aug 2018 20:40:53 -0000 Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.incubator.apache.org Delivered-To: mailing list commits@airflow.incubator.apache.org Received: (qmail 52218 invoked by uid 99); 7 Aug 2018 20:40:53 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Aug 2018 20:40:53 +0000 From: GitBox To: commits@airflow.apache.org Subject: [GitHub] ashb commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines Message-ID: <153367445279.26980.9527856318153494923.gitbox@gitbox.apache.org> Date: Tue, 07 Aug 2018 20:40:52 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ashb commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines URL: https://github.com/apache/incubator-airflow/pull/3714#discussion_r208377732 ########## File path: tests/core.py ########## @@ -2423,7 +2423,7 @@ def test_init_proxy_user(self): class HDFSHookTest(unittest.TestCase): def setUp(self): configuration.load_test_config() - os.environ['AIRFLOW_CONN_HDFS_DEFAULT'] = ('hdfs://localhost:8020') + os.environ['AIRFLOW_CONN_HDFS_DEFAULT'] = 'hdfs://localhost:8020' Review comment: (Not related to this Pr, but we have HDFS tests in core.py? o_O) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services