airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-2989) No Parameter to change bootDiskType for DataprocClusterCreateOperator
Date Thu, 30 Aug 2018 22:31:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16597996#comment-16597996
] 

ASF GitHub Bot commented on AIRFLOW-2989:
-----------------------------------------

kaxil opened a new pull request #3825: [AIRFLOW-2989] Add param to set bootDiskType in Dataproc
Op
URL: https://github.com/apache/incubator-airflow/pull/3825
 
 
   
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/)
issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-2989
   
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   - Add param to set bootDiskType for master and worker nodes in `DataprocClusterCreateOperator`
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   Modified `DataprocClusterCreateOperatorTest`
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use
it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs
to be added.
   
   ### Code Quality
   
   - [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> No Parameter to change bootDiskType for DataprocClusterCreateOperator 
> ----------------------------------------------------------------------
>
>                 Key: AIRFLOW-2989
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2989
>             Project: Apache Airflow
>          Issue Type: New Feature
>          Components: contrib, gcp
>    Affects Versions: 1.9.0, 1.10.0
>            Reporter: Kaxil Naik
>            Assignee: Kaxil Naik
>            Priority: Minor
>             Fix For: 1.10.1
>
>
> Currently, we cannot set the Primary disk type for master and worker to `pd-ssd` for
DataprocClusterCreateOperator.
> Google API: https://cloud.google.com/dataproc/docs/reference/rest/v1/projects.regions.clusters#diskconfig
> Related StackOverflow Issue: https://stackoverflow.com/questions/52090315/airflow-dataprocclustercreateoperator/52092942#52092942



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message