airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Micheal Ascah (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (AIRFLOW-2979) Deprecated Celery Option not in Options list
Date Wed, 29 Aug 2018 19:40:00 GMT

     [ https://issues.apache.org/jira/browse/AIRFLOW-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Micheal Ascah updated AIRFLOW-2979:
-----------------------------------
    Description: 
References AIRFLOW-1840

In airflow/configuration.py
{code:java}
# A two-level mapping of (section -> new_name -> old_name). When reading
# new_name, the old_name will be checked to see if it exists. If it does a
# DeprecationWarning will be issued and the old name will be used instead
deprecated_options = {
    'celery': {
        # Remove these keys in Airflow 1.11
        'worker_concurrency': 'celeryd_concurrency',
        'broker_url': 'celery_broker_url',
        'ssl_active': 'celery_ssl_active',
        'ssl_cert': 'celery_ssl_cert',
        'ssl_key': 'celery_ssl_key',
    }
}
{code}
This block is missing the renaming of celery_result_backend to just result_backed.

 

When setting this through an environment variable, the deprecated config name is not being
used and instead the default value in the file is being used. 

This is obviously remedied by the reading the UPDATING and setting the new name, but this
change has broken back compat as far as I can tell.

  was:
References [AIRFLOW-1840]

In airflow/configuration.py
{code:java}
# A two-level mapping of (section -> new_name -> old_name). When reading
# new_name, the old_name will be checked to see if it exists. If it does a
# DeprecationWarning will be issued and the old name will be used instead
deprecated_options = {
    'celery': {
        # Remove these keys in Airflow 1.11
        'worker_concurrency': 'celeryd_concurrency',
        'broker_url': 'celery_broker_url',
        'ssl_active': 'celery_ssl_active',
        'ssl_cert': 'celery_ssl_cert',
        'ssl_key': 'celery_ssl_key',
    }
}
{code}
This block is missing the renaming of celery_result_backend to just result_backed.

 

When setting this through an environment variable, the deprecated config name is not being
used and instead the default value in the file is being used. 


> Deprecated Celery Option not in Options list 
> ---------------------------------------------
>
>                 Key: AIRFLOW-2979
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2979
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: celery
>    Affects Versions: 1.10.0
>            Reporter: Micheal Ascah
>            Priority: Critical
>
> References AIRFLOW-1840
> In airflow/configuration.py
> {code:java}
> # A two-level mapping of (section -> new_name -> old_name). When reading
> # new_name, the old_name will be checked to see if it exists. If it does a
> # DeprecationWarning will be issued and the old name will be used instead
> deprecated_options = {
>     'celery': {
>         # Remove these keys in Airflow 1.11
>         'worker_concurrency': 'celeryd_concurrency',
>         'broker_url': 'celery_broker_url',
>         'ssl_active': 'celery_ssl_active',
>         'ssl_cert': 'celery_ssl_cert',
>         'ssl_key': 'celery_ssl_key',
>     }
> }
> {code}
> This block is missing the renaming of celery_result_backend to just result_backed.
>  
> When setting this through an environment variable, the deprecated config name is not
being used and instead the default value in the file is being used. 
> This is obviously remedied by the reading the UPDATING and setting the new name, but
this change has broken back compat as far as I can tell.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message