airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-2876) Bump version of Tenacity
Date Wed, 08 Aug 2018 21:23:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-2876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573904#comment-16573904
] 

ASF GitHub Bot commented on AIRFLOW-2876:
-----------------------------------------

Fokko opened a new pull request #3723: [AIRFLOW-2876] Update Tenacity to 4.12
URL: https://github.com/apache/incubator-airflow/pull/3723
 
 
   Tenacity 4.8 is not python 3.7 compatible because it contains reserved keywords in the
code:
   ```
   [2018-08-08 21:21:22,016] {models.py:366} ERROR - Failed to import: /usr/local/lib/python3.7/site-packages/airflow/example_dags/example_http_operator.py
   Traceback (most recent call last):
     File "/usr/local/lib/python3.7/site-packages/airflow/models.py", line 363, in process_file
       m = imp.load_source(mod_name, filepath)
     File "/usr/local/lib/python3.7/imp.py", line 172, in load_source
       module = _load(spec)
     File "<frozen importlib._bootstrap>", line 696, in _load
     File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
     File "<frozen importlib._bootstrap_external>", line 728, in exec_module
     File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
     File "/usr/local/lib/python3.7/site-packages/airflow/example_dags/example_http_operator.py",
line 27, in <module>
       from airflow.operators.http_operator import SimpleHttpOperator
     File "/usr/local/lib/python3.7/site-packages/airflow/operators/http_operator.py", line
21, in <module>
       from airflow.hooks.http_hook import HttpHook
     File "/usr/local/lib/python3.7/site-packages/airflow/hooks/http_hook.py", line 23, in
<module>
       import tenacity
     File "/usr/local/lib/python3.7/site-packages/tenacity/__init__.py", line 352
       from tenacity.async import AsyncRetrying
   ```
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/)
issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-2876
     - In case you are fixing a typo in the documentation you can prepend your commit with
\[AIRFLOW-2876\], code changes always need a Jira issue.
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use
it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs
to be added.
   
   ### Code Quality
   
   - [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Bump version of Tenacity
> ------------------------
>
>                 Key: AIRFLOW-2876
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2876
>             Project: Apache Airflow
>          Issue Type: Bug
>            Reporter: Fokko Driesprong
>            Priority: Major
>
> Since 4.8.0 is not Python 3.7 compatible, we want to bump the version to 4.12.0



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message