airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taylor Edmiston (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (AIRFLOW-2851) Canonicalize "as _..." etc imports
Date Fri, 17 Aug 2018 15:51:00 GMT

     [ https://issues.apache.org/jira/browse/AIRFLOW-2851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Taylor Edmiston resolved AIRFLOW-2851.
--------------------------------------
    Resolution: Resolved

This was resolved via merged PR.

> Canonicalize "as _..." etc imports
> ----------------------------------
>
>                 Key: AIRFLOW-2851
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2851
>             Project: Apache Airflow
>          Issue Type: Improvement
>            Reporter: Taylor Edmiston
>            Assignee: Taylor Edmiston
>            Priority: Minor
>
> This PR:
> 1. Replaces `import foo as _foo` style imports with the more common `import foo` used
everywhere else across the codebase. I dug through history and couldn't find special reasons
to maintain the as style imports here (I think it's just old code). Currently (33dd33c89d4b6454d224ca34bab5ae37fb9812a6),
there are just a handful of import lines using `as _...` vs thousands not using it, so the
goal here is to improve consistency.
> 2. It also simplifies `import foo.bar as bar` style imports to equivalent `from foo import
bar`.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message