airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-2849) devel requirement is not sufficient to check code quality locally
Date Sat, 04 Aug 2018 14:15:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16569192#comment-16569192
] 

ASF GitHub Bot commented on AIRFLOW-2849:
-----------------------------------------

eyaltrabelsi opened a new pull request #3694: [AIRFLOW-2849] Add missing dependency flake8
to setup to allow running code quality checks locally
URL: https://github.com/apache/incubator-airflow/pull/3694
 
 
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [X] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/)
issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your commit with
\[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   ### Tests
   
   - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   Adding dependency.
   
   ### Commits
   
   - [X ] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use
it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs
to be added.
   
   ### Code Quality
   
   - [ X] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> devel requirement is not sufficient to check code quality locally
> -----------------------------------------------------------------
>
>                 Key: AIRFLOW-2849
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2849
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: core
>            Reporter: Eyal Trabelsi
>            Assignee: Eyal Trabelsi
>            Priority: Trivial
>
> The devel requirement doesn't list flake8, but in order to check code quality locally
one need to install it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message