airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-2796) Improve code coverage for utils/helpers.py
Date Thu, 02 Aug 2018 16:49:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-2796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16567056#comment-16567056
] 

ASF GitHub Bot commented on AIRFLOW-2796:
-----------------------------------------

Noremac201 opened a new pull request #3686: [AIRFLOW-2796] Expand code coverage for utils/helpers.py
URL: https://github.com/apache/incubator-airflow/pull/3686
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/)
issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-2796
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   Add more tests for utils/helpers.py
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   
   -`tests/utils/test_helpers.py`
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Improve code coverage for utils/helpers.py
> ------------------------------------------
>
>                 Key: AIRFLOW-2796
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2796
>             Project: Apache Airflow
>          Issue Type: Bug
>            Reporter: Andy Cooper
>            Priority: Trivial
>
> Improve code coverage by adding tests for 
>  * is_container
>  * is_in
>  * as_tuple



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message