airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-2770) kubernetes: add support for dag folder in the docker image
Date Thu, 02 Aug 2018 12:07:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566677#comment-16566677
] 

ASF GitHub Bot commented on AIRFLOW-2770:
-----------------------------------------

yeluolei opened a new pull request #3683: [AIRFLOW-2770] kubernetes: add support for dag folder
in the docker i…
URL: https://github.com/apache/incubator-airflow/pull/3683
 
 
   …mage
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/)
issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-2770
     - In case you are fixing a typo in the documentation you can prepend your commit with
\[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   this change will introduce a new config in kubernetes_executor, `dags_in_docker`, which
means the dags already build in the docker image. thus doesn't need to mount a volume or sync
the dags use git sync. the worker will search the dags from the dags_folder by default. 
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use
it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs
to be added.
   
   ### Code Quality
   
   - [ ] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> kubernetes: add support for dag folder in the docker image
> ----------------------------------------------------------
>
>                 Key: AIRFLOW-2770
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2770
>             Project: Apache Airflow
>          Issue Type: Improvement
>            Reporter: Rurui Ye
>            Assignee: Rurui Ye
>            Priority: Critical
>
> currently the kube executor need to provider dag_volume_chain or git repo in the config
file, but if the user has build dag into their docker image, they doesn't need to provider
these two options, and they can manager their dag version by manager the docker image version. 
> So I suppose we can add the a new configuration as kube.config.dag_folder_path along
with dag_volume_chain and git repo. with this config, we can run the worker just from the
dags in docker image.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message