airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] kaxil commented on a change in pull request #3733: [AIRFLOW-491] Add cache parameter in BigQuery query method - with 'api_resource_configs'
Date Wed, 29 Aug 2018 23:50:58 GMT
kaxil commented on a change in pull request #3733: [AIRFLOW-491] Add cache parameter in BigQuery
query method - with 'api_resource_configs'
URL: https://github.com/apache/incubator-airflow/pull/3733#discussion_r213868479
 
 

 ##########
 File path: airflow/contrib/hooks/bigquery_hook.py
 ##########
 @@ -1114,18 +1184,18 @@ def get_schema(self, dataset_id, table_id):
         :param table_id: the table ID of the requested table
         :return: a table schema
         """
-        tables_resource = self.service.tables() \
-            .get(projectId=self.project_id, datasetId=dataset_id, tableId=table_id) \
-            .execute()
+        tables_resource = self.service.tables().get(
+            projectId=self.project_id, datasetId=dataset_id,
+            tableId=table_id).execute()
         return tables_resource['schema']
 
     def get_tabledata(self, dataset_id, table_id,
                       max_results=None, selected_fields=None, page_token=None,
                       start_index=None):
         """
-        Get the data of a given dataset.table and optionally with selected columns.
-        see https://cloud.google.com/bigquery/docs/reference/v2/tabledata/list
-
+        Get the data of a given dataset.table and optionally
+        with selected columns. see:
+        https://cloud.google.com/bigquery/docs/reference/v2/tabledata/list
 
 Review comment:
   Missing newline between description and params list

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message