airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] XD-DENG commented on issue #3793: [AIRFLOW-2948] Arg check & better doc - SSHOperator & SFTPOperator
Date Sat, 25 Aug 2018 04:21:04 GMT
XD-DENG commented on issue #3793: [AIRFLOW-2948] Arg check & better doc - SSHOperator &
SFTPOperator
URL: https://github.com/apache/incubator-airflow/pull/3793#issuecomment-415934314
 
 
   Hi @feng-tao , I have
   - Added instance checking for argument `ssh_hook`. If `ssh_hook` given by user is not of
class "SSHHook", it would be handled properly.
   - Updated the tests for both operators accordingly and both can pass.
   
   The CI is failing due to:
   - test_poke (tests.contrib.sensors.test_aws_redshift_cluster_sensor.TestAwsRedshiftClusterSensor)
... ERROR
   - test_poke_cluster_not_found (tests.contrib.sensors.test_aws_redshift_cluster_sensor.TestAwsRedshiftClusterSensor)
... ERROR
   - test_poke_false (tests.contrib.sensors.test_aws_redshift_cluster_sensor.TestAwsRedshiftClusterSensor)
... ERROR
   
   None of these test cases were touched in this PR. Seems it's exceptions like `Unable to
locate credentials`. Not sure what is happening.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message