airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] feng-tao commented on a change in pull request #3785: [AIRFLOW-2938] Handle improperly formatted extra field in connection …
Date Wed, 22 Aug 2018 23:54:27 GMT
feng-tao commented on a change in pull request #3785: [AIRFLOW-2938] Handle improperly formatted
extra field in connection …
URL: https://github.com/apache/incubator-airflow/pull/3785#discussion_r212146153
 
 

 ##########
 File path: airflow/www_rbac/views.py
 ##########
 @@ -1923,7 +1923,10 @@ def prefill_form(self, form, pk):
             d = {}
 
         for field in self.extra_fields:
-            value = d.get(field, '')
+            try:
+                value = d.get(field, '')
+            except Exception:
 
 Review comment:
   so the json.loads sometimes will return non dictionary object which causes the exception?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message