airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] xnuinside commented on a change in pull request #3733: [AIRFLOW-491] Add cache parameter in BigQuery query method - with 'api_resource_configs'
Date Tue, 21 Aug 2018 14:45:51 GMT
xnuinside commented on a change in pull request #3733: [AIRFLOW-491] Add cache parameter in
BigQuery query method - with 'api_resource_configs'
URL: https://github.com/apache/incubator-airflow/pull/3733#discussion_r211634204
 
 

 ##########
 File path: airflow/contrib/hooks/bigquery_hook.py
 ##########
 @@ -656,6 +671,10 @@ def run_query(self,
                 configuration['query'][
                     'schemaUpdateOptions'] = schema_update_options
 
+        if 'configuration' in api_resource_configs:
 
 Review comment:
   I thought about this param like a possibility to set any settings in one dict, that supported
by API (because of 'src_fmt_configs'). But if we say what it's only the way to set 'configuration'
and we will not available this way to send any other params, for example, 'jobReference' or
'statistics' .. so way what I could define one dict with all params and send it. So if it's
not needed and it will be only for 'configuration' - it's of course not needed. What do you
think? Use it only for 'configuration' ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message