airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] xnuinside commented on a change in pull request #3733: [AIRFLOW-491] Add cache parameter in BigQuery query method - with 'api_resource_configs'
Date Tue, 21 Aug 2018 14:23:46 GMT
xnuinside commented on a change in pull request #3733: [AIRFLOW-491] Add cache parameter in
BigQuery query method - with 'api_resource_configs'
URL: https://github.com/apache/incubator-airflow/pull/3733#discussion_r211625138
 
 

 ##########
 File path: airflow/contrib/hooks/bigquery_hook.py
 ##########
 @@ -656,6 +671,10 @@ def run_query(self,
                 configuration['query'][
                     'schemaUpdateOptions'] = schema_update_options
 
+        if 'configuration' in api_resource_configs:
+            for key in api_resource_configs['configuration']:
+                configuration[key] = api_resource_configs['configuration'][key]
 
 Review comment:
   mm.. no, it will re-write only keys what will be added by the user in api_resource_configs,
or I didn't catch what you mean.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message