airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] XD-DENG edited a comment on issue #3773: [AIRFLOW-2921][AIRFLOW-2922] Fix two potential bugs in CeleryExecutor()
Date Mon, 20 Aug 2018 14:47:26 GMT
XD-DENG edited a comment on issue #3773: [AIRFLOW-2921][AIRFLOW-2922] Fix two potential bugs
in CeleryExecutor()
URL: https://github.com/apache/incubator-airflow/pull/3773#issuecomment-414338614
 
 
   Hi @ashb,
   
   1. Test case has been updated for the ***potential bug-1***, based on the existing test
case.
   
   2. To demonstrate the ***potential bug-1***, I have created another branch in which I updated
the test case but did NOT fix the code. This bug is quite obvious. ['Reverse Test' Commit
Link](https://github.com/XD-DENG/incubator-airflow/commit/957ea4cc32ea6158c97c9d782fd2ceca42bb6c37),
[Test Result Link](https://travis-ci.org/XD-DENG/incubator-airflow/jobs/418245043#L5531)
   
   3. Regarding the ***potential bug-2***, please refer to my detailed description in the
main PR message. Currently I don't see a feasible way to reproduce the potential error/test
it yet.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message