airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] Fokko commented on a change in pull request #3767: [AIRFLOW-2524]Add SageMaker Batch Inference
Date Mon, 20 Aug 2018 09:24:22 GMT
Fokko commented on a change in pull request #3767: [AIRFLOW-2524]Add SageMaker Batch Inference
URL: https://github.com/apache/incubator-airflow/pull/3767#discussion_r211103951
 
 

 ##########
 File path: airflow/contrib/hooks/sagemaker_hook.py
 ##########
 @@ -86,6 +86,16 @@ def check_valid_tuning_input(self, tuning_config):
             self.check_for_url(channel['DataSource']
                                ['S3DataSource']['S3Uri'])
 
+    def check_valid_transform_input(self, transform_config):
 
 Review comment:
   This function feels a bit silly to me, why not `check_for_url` directly?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message