airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] bolkedebruin commented on issue #3743: [AIRFLOW-2799] Filtering UI objects by datetime is broken
Date Wed, 15 Aug 2018 11:56:16 GMT
bolkedebruin commented on issue #3743: [AIRFLOW-2799] Filtering UI objects by datetime is broken
URL: https://github.com/apache/incubator-airflow/pull/3743#issuecomment-413176105
 
 
   Hi @kevcampb. Thanks for your contribution. Unfortunately, this is not a fix. It assumes
that the system (and client) is running in UTC which it might not be. I don't think undefined
behavior in case of non UTC is better than a crash. Obviously, a crash is not what we want,
but it should be fixed properly. Also as it crashed now, please make sure to add a test to
ensure that doesn't happen any more in the future.
   
   I also miss a proper root cause analysis and therefore an approach to the right fix. Finally,
it will need to pass the flake8 tests which are differential tests. The existing situation
we would like to improve upon. Please also provide a proper commit message according to the
guidelines.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message