airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ashb commented on a change in pull request #3740: [AIRFLOW-2888] Remove shell=True and bash from task launch
Date Tue, 14 Aug 2018 18:23:50 GMT
ashb commented on a change in pull request #3740: [AIRFLOW-2888] Remove shell=True and bash
from task launch
URL: https://github.com/apache/incubator-airflow/pull/3740#discussion_r210055138
 
 

 ##########
 File path: airflow/config_templates/default_airflow.cfg
 ##########
 @@ -140,7 +140,7 @@ donot_pickle = False
 dagbag_import_timeout = 30
 
 # The class to use for running task instances in a subprocess
-task_runner = BashTaskRunner
+task_runner = StandardTaskRunner
 
 Review comment:
   So, because of our approach of writing out a copy of the default_airflow.cfg as airflow.cfg
on first run anyone upgrading will have their task_runner configured to BashTaskRunner, so
we'll at least need to mention this in the UPDATING instructions for people upgrading.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message