airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] feng-tao commented on a change in pull request #3475: [AIRFLOW-2315] Improve S3Hook
Date Thu, 09 Aug 2018 17:26:32 GMT
feng-tao commented on a change in pull request #3475: [AIRFLOW-2315] Improve S3Hook
URL: https://github.com/apache/incubator-airflow/pull/3475#discussion_r209012321
 
 

 ##########
 File path: airflow/hooks/S3_hook.py
 ##########
 @@ -312,7 +312,8 @@ def load_string(self,
                     bucket_name=None,
                     replace=False,
                     encrypt=False,
-                    encoding='utf-8'):
+                    encoding='utf-8',
+                    upload_args={}):
 
 Review comment:
   nit: same

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message