airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] Fokko commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines
Date Wed, 08 Aug 2018 07:40:17 GMT
Fokko commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform
Python standards & guidelines
URL: https://github.com/apache/incubator-airflow/pull/3714#discussion_r208483352
 
 

 ##########
 File path: airflow/contrib/operators/mongo_to_s3.py
 ##########
 @@ -105,7 +106,8 @@ def _stringify(self, iterable, joinable='\n'):
             [json.dumps(doc, default=json_util.default) for doc in iterable]
         )
 
-    def transform(self, docs):
+    @staticmethod
 
 Review comment:
   Nit, I always put static function above the non-static one in the class order

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message