airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] feng-tao commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines
Date Tue, 07 Aug 2018 22:45:32 GMT
feng-tao commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform
Python standards & guidelines
URL: https://github.com/apache/incubator-airflow/pull/3714#discussion_r208408365
 
 

 ##########
 File path: airflow/contrib/hooks/databricks_hook.py
 ##########
 @@ -65,7 +65,8 @@ def __init__(
             raise ValueError('Retry limit must be greater than equal to 1')
         self.retry_limit = retry_limit
 
-    def _parse_host(self, host):
+    @staticmethod
 
 Review comment:
   do you change the place where it uses this method?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message