airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ashb commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines
Date Tue, 07 Aug 2018 20:40:52 GMT
ashb commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python
standards & guidelines
URL: https://github.com/apache/incubator-airflow/pull/3714#discussion_r208377732
 
 

 ##########
 File path: tests/core.py
 ##########
 @@ -2423,7 +2423,7 @@ def test_init_proxy_user(self):
 class HDFSHookTest(unittest.TestCase):
     def setUp(self):
         configuration.load_test_config()
-        os.environ['AIRFLOW_CONN_HDFS_DEFAULT'] = ('hdfs://localhost:8020')
+        os.environ['AIRFLOW_CONN_HDFS_DEFAULT'] = 'hdfs://localhost:8020'
 
 Review comment:
   (Not related to this Pr, but we have HDFS tests in core.py? o_O)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message