airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] kaxil opened a new pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines
Date Tue, 07 Aug 2018 20:17:23 GMT
kaxil opened a new pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards
& guidelines
URL: https://github.com/apache/incubator-airflow/pull/3714
 
 
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/)
issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-2867
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   - Dictionary creation should be written by dictionary literal
   - Python’s default arguments are evaluated once when the function is defined, not each
time the function is called (like it is in say, Ruby). This means that if you use a mutable
default argument and mutate it, you will and have mutated that object for all future calls
to the function as well.
   - Functions calling sets which can be replaced by set literal are now replaced by set literal
   - Replace list literals
   - Some of the static methods haven't been set static
   - Remove redundant parentheses
   
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   N/a, Nothing new added
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use
it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs
to be added.
   
   ### Code Quality
   
   - [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message