airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ashb commented on a change in pull request #3713: [AIRFLOW-2428] Add AutoScalingRole key to emr_hook
Date Tue, 07 Aug 2018 15:03:58 GMT
ashb commented on a change in pull request #3713: [AIRFLOW-2428] Add AutoScalingRole key to
emr_hook
URL: https://github.com/apache/incubator-airflow/pull/3713#discussion_r208267811
 
 

 ##########
 File path: airflow/contrib/hooks/emr_hook.py
 ##########
 @@ -63,6 +63,8 @@ def create_job_flow(self, job_flow_overrides):
             VisibleToAllUsers=config.get('VisibleToAllUsers'),
             JobFlowRole=config.get('JobFlowRole'),
             ServiceRole=config.get('ServiceRole'),
+            AutoScalingRole=config.get('AutoScalingRole'),
+            ScaleDownBehavior=config.get('ScaleDownBehavior'),            
             Tags=config.get('Tags')
 
 Review comment:
   Hmmm, I wonder if it might be an idea to do `self.get_conn().run_job_flow(**config)` -
that we don't have to stay up-to-date with the AWS API.
   
   For that to work we'd need three `config.setdefault()` calls for the three list-types.
I also don't know if all the kwargs are optional or not (but I suspect they are).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message