airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] bolkedebruin commented on a change in pull request #3710: [AIRFLOW-2860] Update tests for druid hook
Date Mon, 06 Aug 2018 18:47:43 GMT
bolkedebruin commented on a change in pull request #3710: [AIRFLOW-2860] Update tests for druid
hook
URL: https://github.com/apache/incubator-airflow/pull/3710#discussion_r207992729
 
 

 ##########
 File path: airflow/hooks/druid_hook.py
 ##########
 @@ -53,6 +54,8 @@ def __init__(
         self.max_ingestion_time = max_ingestion_time
         self.header = {'content-type': 'application/json'}
 
+        assert self.timeout >= 1
 
 Review comment:
   Also please use self.assertXXX otherwise we won't see causes.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message