airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] Cplo opened a new pull request #3697: [AIRFLOW-2854] kubernetes_pod_operator add more configuration items
Date Sun, 05 Aug 2018 05:48:11 GMT
Cplo opened a new pull request #3697: [AIRFLOW-2854] kubernetes_pod_operator add more configuration
items
URL: https://github.com/apache/incubator-airflow/pull/3697
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/)
issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-2854
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   kubernetes_pod_operator is missing kubernetes pods related configuration items, as follows:
   
   1. image_pull_secrets
   
   Pull secrets are used to pull private container images from registries. In this case, we
need to configure the image_pull_secrets in pod spec file
   
   2. service_account_name
   
   When kubernetes is running on rbac Authorization. If it is a job that needs to operate
on kubernetes resources, we need to configure service account.
   
   3. is_delete_operator_pod
   
   This option can be given to the user to decide whether to delete the job pod created by
pod_operator, which is currently not processed.
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use
it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs
to be added.
   
   ### Code Quality
   
   - [ ] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message