airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-2814) Default Arg "file_process_interval" for class SchedulerJob is inconsistent with doc
Date Tue, 31 Jul 2018 23:07:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564480#comment-16564480
] 

ASF GitHub Bot commented on AIRFLOW-2814:
-----------------------------------------

codecov-io commented on issue #3669: Revert [AIRFLOW-2814] - Change `min_file_process_interval`
to 0
URL: https://github.com/apache/incubator-airflow/pull/3669#issuecomment-409396427
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3669?src=pr&el=h1)
Report
   > Merging [#3669](https://codecov.io/gh/apache/incubator-airflow/pull/3669?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/incubator-airflow/commit/ed972042a864cd010137190e0bbb1d25a9dcfe83?src=pr&el=desc)
will **increase** coverage by `0.27%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-airflow/pull/3669/graphs/tree.svg?token=WdLKlKHOAU&src=pr&width=650&height=150)](https://codecov.io/gh/apache/incubator-airflow/pull/3669?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #3669      +/-   ##
   ==========================================
   + Coverage   77.51%   77.79%   +0.27%     
   ==========================================
     Files         205      205              
     Lines       15751    16079     +328     
   ==========================================
   + Hits        12210    12508     +298     
   - Misses       3541     3571      +30
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-airflow/pull/3669?src=pr&el=tree)
| Coverage Δ | |
   |---|---|---|
   | [airflow/jobs.py](https://codecov.io/gh/apache/incubator-airflow/pull/3669/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzLnB5)
| `84.63% <ø> (+1.88%)` | :arrow_up: |
   | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/incubator-airflow/pull/3669/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
| `89.45% <0%> (-0.43%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3669?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3669?src=pr&el=footer).
Last update [ed97204...1ee1fc4](https://codecov.io/gh/apache/incubator-airflow/pull/3669?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Default Arg "file_process_interval" for class SchedulerJob is inconsistent with doc
> -----------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-2814
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2814
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: scheduler
>            Reporter: Xiaodong DENG
>            Assignee: Xiaodong DENG
>            Priority: Critical
>             Fix For: 2.0.0
>
>
> h2. Backgrond
> In [https://github.com/XD-DENG/incubator-airflow/blob/master/airflow/jobs.py#L592] ,
it was mentioned the default value of argument *file_process_interval* should be 3 minutes
(*file_process_interval:* Parse and schedule each file no faster than this interval).
> The value is normally parsed from the default configuration. However, in the default
config_template, its value is 0 rather than 180 seconds ([https://github.com/XD-DENG/incubator-airflow/blob/master/airflow/config_templates/default_airflow.cfg#L432] ). 
> h2. Issue
> This means that actually that each file is parsed and scheduled without letting Airflow
"rest". This conflicts with the design purpose (by default let it be 180 seconds) and may
affect performance significantly.
> h2. My Proposal
> Change the value in the config template from 0 to 180.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message