airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-2803) Fix all ESLint issues
Date Tue, 31 Jul 2018 15:39:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-2803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563848#comment-16563848
] 

ASF GitHub Bot commented on AIRFLOW-2803:
-----------------------------------------

tedmiston edited a comment on issue #3656: [WIP][AIRFLOW-2803] Fix all ESLint issues
URL: https://github.com/apache/incubator-airflow/pull/3656#issuecomment-409266326
 
 
   @verdan Sure!  Typically I keep atomic commits while I'm working so everyone can follow
small changes instead of one big diff, then squash down to one commit at the end.  I updated
the title to make it clear this is WIP.  Since you're doing most of the reviewing here, do
you have a preference on squashing throughout working vs just thinking about preparing for
the merge with squashing at the end?
   
   I should have an update later today btw.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Fix all ESLint issues
> ---------------------
>
>                 Key: AIRFLOW-2803
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2803
>             Project: Apache Airflow
>          Issue Type: Improvement
>            Reporter: Verdan Mahmood
>            Assignee: Taylor Edmiston
>            Priority: Major
>
> Most of the JS code in Apache Airflow has linting issues which are highlighted after
the integration of ESLint. 
> Once AIRFLOW-2783 merged in master branch, please fix all the javascript styling issues
that we have in .js and .html files. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message