airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-2803) Fix all ESLint issues
Date Mon, 30 Jul 2018 20:37:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-2803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562468#comment-16562468
] 

ASF GitHub Bot commented on AIRFLOW-2803:
-----------------------------------------

codecov-io edited a comment on issue #3656: [AIRFLOW-2803] Fix all ESLint issues
URL: https://github.com/apache/incubator-airflow/pull/3656#issuecomment-408503531
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3656?src=pr&el=h1)
Report
   > Merging [#3656](https://codecov.io/gh/apache/incubator-airflow/pull/3656?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/incubator-airflow/commit/a338f3276835af45765d24a6e6d43ad4ba4d66ba?src=pr&el=desc)
will **increase** coverage by `0.39%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-airflow/pull/3656/graphs/tree.svg?height=150&width=650&token=WdLKlKHOAU&src=pr)](https://codecov.io/gh/apache/incubator-airflow/pull/3656?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #3656      +/-   ##
   ==========================================
   + Coverage   77.12%   77.51%   +0.39%     
   ==========================================
     Files         206      205       -1     
     Lines       15772    15751      -21     
   ==========================================
   + Hits        12164    12210      +46     
   + Misses       3608     3541      -67
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-airflow/pull/3656?src=pr&el=tree)
| Coverage Δ | |
   |---|---|---|
   | [airflow/www/app.py](https://codecov.io/gh/apache/incubator-airflow/pull/3656/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5)
| `99.01% <0%> (-0.99%)` | :arrow_down: |
   | [airflow/minihivecluster.py](https://codecov.io/gh/apache/incubator-airflow/pull/3656/diff?src=pr&el=tree#diff-YWlyZmxvdy9taW5paGl2ZWNsdXN0ZXIucHk=)
| | |
   | [airflow/models.py](https://codecov.io/gh/apache/incubator-airflow/pull/3656/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMucHk=)
| `88.58% <0%> (+0.04%)` | :arrow_up: |
   | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/incubator-airflow/pull/3656/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
| `89.87% <0%> (+0.42%)` | :arrow_up: |
   | [airflow/hooks/pig\_hook.py](https://codecov.io/gh/apache/incubator-airflow/pull/3656/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9waWdfaG9vay5weQ==)
| `100% <0%> (+100%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3656?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3656?src=pr&el=footer).
Last update [a338f32...b65388a](https://codecov.io/gh/apache/incubator-airflow/pull/3656?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Fix all ESLint issues
> ---------------------
>
>                 Key: AIRFLOW-2803
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2803
>             Project: Apache Airflow
>          Issue Type: Improvement
>            Reporter: Verdan Mahmood
>            Assignee: Taylor Edmiston
>            Priority: Major
>
> Most of the JS code in Apache Airflow has linting issues which are highlighted after
the integration of ESLint. 
> Once AIRFLOW-2783 merged in master branch, please fix all the javascript styling issues
that we have in .js and .html files. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message