airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-2670) SSHOperator's timeout parameter doesn't affect SSHook timeoot
Date Mon, 30 Jul 2018 21:35:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-2670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562541#comment-16562541
] 

ASF GitHub Bot commented on AIRFLOW-2670:
-----------------------------------------

Noremac201 opened a new pull request #3666: [AIRFLOW-2670] Update SSH Operator's Hook to respect
timeout
URL: https://github.com/apache/incubator-airflow/pull/3666
 
 
   ### JIRA
   - [x] My PR addresses the following [Airflow JIRA](https://issues.apache.org/jira/browse/AIRFLOW/)
issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
       - https://issues.apache.org/jira/browse/AIRFLOW-2670
   
   ### Description
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   Previously the SSH operator was not respecting the passed in timeout to the operator. Changed
the Operator to pass the timeout to hook, as well as add a test to make sure the hook is being
created correctly.
   
   Extension of #3553, mistakenly closed after I thought it was fixed elsewhere.
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   
   ### Code Quality
   - [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> SSHOperator's timeout parameter doesn't affect SSHook timeoot
> -------------------------------------------------------------
>
>                 Key: AIRFLOW-2670
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2670
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: contrib
>    Affects Versions: Airflow 2.0
>            Reporter: jin zhang
>            Priority: Major
>
> when I use SSHOperator, SSHOperator's timeout parameter can't set in SSHHook and it's
just effect exce_command. 
> old version:
> self.ssh_hook = SSHHook(ssh_conn_id=self.ssh_conn_id)
> I change it to :
> self.ssh_hook = SSHHook(ssh_conn_id=self.ssh_conn_id, timeout=self.timeout)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message