airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Fokko Driesprong (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (AIRFLOW-2292) Fix docstring for S3Hook.get_wildcard_key
Date Sun, 08 Apr 2018 18:16:00 GMT

     [ https://issues.apache.org/jira/browse/AIRFLOW-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Fokko Driesprong resolved AIRFLOW-2292.
---------------------------------------
       Resolution: Fixed
    Fix Version/s: 2.0.0

Issue resolved by pull request #3196
[https://github.com/apache/incubator-airflow/pull/3196]

> Fix docstring for S3Hook.get_wildcard_key
> -----------------------------------------
>
>                 Key: AIRFLOW-2292
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2292
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: docs, Documentation
>            Reporter: Kengo Seki
>            Assignee: Kengo Seki
>            Priority: Minor
>             Fix For: 2.0.0
>
>
> S3Hook.get_wildcard_key's docstring says as follows, but the right name is {{wildcard_key}}.
It's doubly misleading since the pattern must be specified as glob, not regex.
> {code:python}
>     def get_wildcard_key(self, wildcard_key, bucket_name=None, delimiter=''):
>         """
>         Returns a boto3.s3.Object object matching the regular expression
>         :param regex_key: the path to the key
>         :type regex_key: str
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message