airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-1623) Clearing task in UI does not trigger on_kill method in operator
Date Wed, 11 Apr 2018 06:06:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433447#comment-16433447
] 

ASF subversion and git services commented on AIRFLOW-1623:
----------------------------------------------------------

Commit 39b7d7d87cabae9de02ba5d64b998317b494bdd9 in incubator-airflow's branch refs/heads/master
from [~bolke]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=39b7d7d ]

[AIRFLOW-1623] Trigger on_kill method in operators

on_kill methods were not triggered, due to
processes
not being properly terminated. This was due to the
fact
the runners use a shell which is then replaced by
the
child pid, which is unknown to Airflow.

Closes #3204 from bolkedebruin/AIRFLOW-1623


> Clearing task in UI does not trigger on_kill method in operator
> ---------------------------------------------------------------
>
>                 Key: AIRFLOW-1623
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-1623
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: operators
>    Affects Versions: Airflow 2.0
>            Reporter: Richard Penman
>            Priority: Major
>             Fix For: 1.10.0
>
>
> When a task is cleared in the UI it doesn't call the [operators on_kill() method|https://github.com/apache/incubator-airflow/blob/b2e1753f5b74ad1b6e0889f7b784ce69623c95ce/airflow/models.py#L2380]
to clean up the task. Apparently this is meant to be handled in the [LocalTaskJob.on_kill()|https://github.com/apache/incubator-airflow/blob/b2e1753f5b74ad1b6e0889f7b784ce69623c95ce/airflow/jobs.py#L2512]
method, however it is not currently.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message