From commits-return-12379-archive-asf-public=cust-asf.ponee.io@airflow.incubator.apache.org Sun Feb 4 14:40:04 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 7D84818064A for ; Sun, 4 Feb 2018 14:40:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 6CFB4160C59; Sun, 4 Feb 2018 13:40:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B5C2D160C37 for ; Sun, 4 Feb 2018 14:40:03 +0100 (CET) Received: (qmail 56372 invoked by uid 500); 4 Feb 2018 13:40:02 -0000 Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.incubator.apache.org Delivered-To: mailing list commits@airflow.incubator.apache.org Received: (qmail 56362 invoked by uid 99); 4 Feb 2018 13:40:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 04 Feb 2018 13:40:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 5B2351A00D3 for ; Sun, 4 Feb 2018 13:40:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id PwcpbmXQJtQ7 for ; Sun, 4 Feb 2018 13:40:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 524865F6C2 for ; Sun, 4 Feb 2018 13:40:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D92D1E024A for ; Sun, 4 Feb 2018 13:40:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6DDBD21E87 for ; Sun, 4 Feb 2018 13:40:00 +0000 (UTC) Date: Sun, 4 Feb 2018 13:40:00 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: commits@airflow.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AIRFLOW-1793) DockerOperator doesn't work with docker_conn_id MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AIRFLOW-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351786#comment-16351786 ] ASF subversion and git services commented on AIRFLOW-1793: ---------------------------------------------------------- Commit 6f60304529a6db0fc050590b821b288d64dcd992 in incubator-airflow's branch refs/heads/master from kodieg [ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=6f60304 ] [AIRFLOW-1793] Use docker_url instead of invalid base_url Closes #2998 from kodieg/patch-3 > DockerOperator doesn't work with docker_conn_id > ----------------------------------------------- > > Key: AIRFLOW-1793 > URL: https://issues.apache.org/jira/browse/AIRFLOW-1793 > Project: Apache Airflow > Issue Type: Bug > Reporter: Cedrik Neumann > Assignee: Cedrik Neumann > Priority: Major > > The implementation of DockerOperator uses `self.base_url` when loading the DockerHook instead of `self.docker_url`: > https://github.com/apache/incubator-airflow/blob/v1-9-stable/airflow/operators/docker_operator.py#L150 > {noformat} > [2017-11-08 16:10:13,082] {base_task_runner.py:98} INFO - Subtask: File "/src/apache-airflow/airflow/operators/docker_operator.py", line 161, in execute > [2017-11-08 16:10:13,083] {base_task_runner.py:98} INFO - Subtask: self.cli = self.get_hook().get_conn() > [2017-11-08 16:10:13,083] {base_task_runner.py:98} INFO - Subtask: File "/src/apache-airflow/airflow/operators/docker_operator.py", line 150, in get_hook > [2017-11-08 16:10:13,083] {base_task_runner.py:98} INFO - Subtask: base_url=self.base_url, > [2017-11-08 16:10:13,083] {base_task_runner.py:98} INFO - Subtask: AttributeError: 'DockerOperator' object has no attribute 'base_url' > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)