From commits-return-12349-archive-asf-public=cust-asf.ponee.io@airflow.incubator.apache.org Fri Feb 2 09:31:49 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id D2CB5180608 for ; Fri, 2 Feb 2018 09:31:49 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id C206A160C49; Fri, 2 Feb 2018 08:31:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 155B3160C41 for ; Fri, 2 Feb 2018 09:31:48 +0100 (CET) Received: (qmail 89752 invoked by uid 500); 2 Feb 2018 08:31:48 -0000 Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.incubator.apache.org Delivered-To: mailing list commits@airflow.incubator.apache.org Received: (qmail 89743 invoked by uid 99); 2 Feb 2018 08:31:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Feb 2018 08:31:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id CA27C18E888 for ; Fri, 2 Feb 2018 08:31:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.23 X-Spam-Level: X-Spam-Status: No, score=-4.23 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id JgSg1lF9HI9h for ; Fri, 2 Feb 2018 08:31:43 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 3A23A5F1EE for ; Fri, 2 Feb 2018 08:31:42 +0000 (UTC) Received: (qmail 89713 invoked by uid 99); 2 Feb 2018 08:31:41 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Feb 2018 08:31:41 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 2EE9EDFC27; Fri, 2 Feb 2018 08:31:41 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: fokko@apache.org To: commits@airflow.incubator.apache.org Message-Id: <83bf3fbf587f4b29ac3fc36d94a4244a@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: incubator-airflow git commit: [AIRFLOW-2053] Fix quote character bug in BQ hook Date: Fri, 2 Feb 2018 08:31:41 +0000 (UTC) Repository: incubator-airflow Updated Branches: refs/heads/master ba0b1978d -> fd4360b9f [AIRFLOW-2053] Fix quote character bug in BQ hook Modified the condition to check if the quote_character is set. This will allow to set `quote_character` as empty string when the data doesn't contain quoted sections. Closes #2996 from kaxil/bq_hook_quote_fix Project: http://git-wip-us.apache.org/repos/asf/incubator-airflow/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-airflow/commit/fd4360b9 Tree: http://git-wip-us.apache.org/repos/asf/incubator-airflow/tree/fd4360b9 Diff: http://git-wip-us.apache.org/repos/asf/incubator-airflow/diff/fd4360b9 Branch: refs/heads/master Commit: fd4360b9f0954b3dd4a960153178a06112f05a33 Parents: ba0b197 Author: Kaxil Naik Authored: Fri Feb 2 09:31:35 2018 +0100 Committer: Fokko Driesprong Committed: Fri Feb 2 09:31:35 2018 +0100 ---------------------------------------------------------------------- airflow/contrib/hooks/bigquery_hook.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-airflow/blob/fd4360b9/airflow/contrib/hooks/bigquery_hook.py ---------------------------------------------------------------------- diff --git a/airflow/contrib/hooks/bigquery_hook.py b/airflow/contrib/hooks/bigquery_hook.py index cd6bf32..120cee0 100644 --- a/airflow/contrib/hooks/bigquery_hook.py +++ b/airflow/contrib/hooks/bigquery_hook.py @@ -799,7 +799,7 @@ class BigQueryBaseCursor(LoggingMixin): src_fmt_configs['skipLeadingRows'] = skip_leading_rows if 'fieldDelimiter' not in src_fmt_configs: src_fmt_configs['fieldDelimiter'] = field_delimiter - if quote_character: + if quote_character is not None: src_fmt_configs['quote'] = quote_character if allow_quoted_newlines: src_fmt_configs['allowQuotedNewlines'] = allow_quoted_newlines