airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-2073) FileSensor always return True
Date Thu, 08 Feb 2018 20:52:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16357547#comment-16357547
] 

ASF subversion and git services commented on AIRFLOW-2073:
----------------------------------------------------------

Commit 4751abf8acad766cb576ecfe3a333d68cc693b8c in incubator-airflow's branch refs/heads/master
from [~ashb]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=4751abf ]

[AIRFLOW-2073] Make FileSensor fail when the file doesn't exist

Previously it never returned False because os.walk
never failed.

It also wasn't clear the behaviour of this sensor
should have when given
a directory. I think the most useful behaviour
would be to wait for any
files to exist, rather than returning as soon as
the directory itself
exists.

Closes #3017 from ashb/AIRFLOW-2073-file-sensor-
never-failed


> FileSensor always return True
> -----------------------------
>
>                 Key: AIRFLOW-2073
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2073
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: contrib
>    Affects Versions: 1.9.0
>         Environment: Ubuntu 16.04
>            Reporter: Pierre Payet
>            Priority: Trivial
>             Fix For: 1.10.0
>
>
> When using a FileSensor, the path is tested with os.walk. However, this function never
raise an error if the path does not exist and the poke will always return True.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message