airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-2034) mixup between %s and {} when using str.format
Date Sun, 25 Feb 2018 11:33:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376056#comment-16376056
] 

ASF subversion and git services commented on AIRFLOW-2034:
----------------------------------------------------------

Commit 6efe2e3ce050264b580d11f3cffb109e8aef5bbd in incubator-airflow's branch refs/heads/master
from [~knil-sama]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=6efe2e3 ]

[AIRFLOW-2034] Fix mixup between %s and {} when using str.format
Convention is to use .format for string formating oustide logging, else use lazy format
See comment in related issue
https://github.com/apache/incubator-airflow/pull/2823/files
Identified problematic case using following command line
.git/COMMIT_EDITMSG:`grep -r '%s'./* | grep '\.format('`

Closes #2976 from knil-sama/fix-mixup-format-str


> mixup between %s and {} when using str.format
> ---------------------------------------------
>
>                 Key: AIRFLOW-2034
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2034
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: hooks
>    Affects Versions: 1.9.0
>            Reporter: knil-sama
>            Assignee: knil-sama
>            Priority: Trivial
>              Labels: easyfix
>             Fix For: 1.9.0
>
>
> Convention is to use .format for string formating outside logging, else use lazy formation
>  See comment in related issue
>  #[https://github.com/apache/incubator-airflow/pull/2823/files]
> But some code didn't implement it correctly.
> Problematic cases can be identified using following command line
> {{grep -r '%s'./* | grep '\.format('}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message