airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fo...@apache.org
Subject incubator-airflow git commit: [AIRFLOW-2074] Fix log var name in GHE auth
Date Wed, 07 Feb 2018 08:31:27 GMT
Repository: incubator-airflow
Updated Branches:
  refs/heads/master 772dbae29 -> 718483b9d


[AIRFLOW-2074] Fix log var name in GHE auth

A previous log refactor changed the logger name
from `_log` to `log`,
but didn't update callers.

Closes #3011 from cmlad/fix-ghe-auth-logging


Project: http://git-wip-us.apache.org/repos/asf/incubator-airflow/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-airflow/commit/718483b9
Tree: http://git-wip-us.apache.org/repos/asf/incubator-airflow/tree/718483b9
Diff: http://git-wip-us.apache.org/repos/asf/incubator-airflow/diff/718483b9

Branch: refs/heads/master
Commit: 718483b9d7825ce3ed39117885d46e2a0dbc1aa3
Parents: 772dbae
Author: Christian Mladenov <cm@coinbase.com>
Authored: Wed Feb 7 09:31:21 2018 +0100
Committer: Fokko Driesprong <fokkodriesprong@godatadriven.com>
Committed: Wed Feb 7 09:31:21 2018 +0100

----------------------------------------------------------------------
 airflow/contrib/auth/backends/github_enterprise_auth.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-airflow/blob/718483b9/airflow/contrib/auth/backends/github_enterprise_auth.py
----------------------------------------------------------------------
diff --git a/airflow/contrib/auth/backends/github_enterprise_auth.py b/airflow/contrib/auth/backends/github_enterprise_auth.py
index e4665cb..2d7b345 100644
--- a/airflow/contrib/auth/backends/github_enterprise_auth.py
+++ b/airflow/contrib/auth/backends/github_enterprise_auth.py
@@ -119,7 +119,7 @@ class GHEAuthBackend(object):
                                     self.oauth_callback)
 
     def login(self, request):
-        _log.debug('Redirecting user to GHE login')
+        log.debug('Redirecting user to GHE login')
         return self.ghe_oauth.authorize(callback=url_for(
             'ghe_oauth_callback',
             _external=True,
@@ -169,7 +169,7 @@ class GHEAuthBackend(object):
             if team['id'] in allowed_teams:
                 return True
 
-        _log.debug('Denying access for user "%s", not a member of "%s"',
+        log.debug('Denying access for user "%s", not a member of "%s"',
                    username,
                    str(allowed_teams))
 
@@ -186,7 +186,7 @@ class GHEAuthBackend(object):
 
     @provide_session
     def oauth_callback(self, session=None):
-        _log.debug('GHE OAuth callback called')
+        log.debug('GHE OAuth callback called')
 
         next_url = request.args.get('next') or url_for('admin.index')
 
@@ -206,7 +206,7 @@ class GHEAuthBackend(object):
                 return redirect(url_for('airflow.noaccess'))
 
         except AuthenticationError:
-            _log.exception('')
+            log.exception('')
             return redirect(url_for('airflow.noaccess'))
 
         user = session.query(models.User).filter(


Mime
View raw message