From commits-return-12120-archive-asf-public=cust-asf.ponee.io@airflow.incubator.apache.org Wed Jan 17 22:09:08 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 5383C18062C for ; Wed, 17 Jan 2018 22:09:08 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 4385B160C35; Wed, 17 Jan 2018 21:09:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8A57B160C25 for ; Wed, 17 Jan 2018 22:09:07 +0100 (CET) Received: (qmail 8082 invoked by uid 500); 17 Jan 2018 21:09:06 -0000 Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.incubator.apache.org Delivered-To: mailing list commits@airflow.incubator.apache.org Received: (qmail 8073 invoked by uid 99); 17 Jan 2018 21:09:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Jan 2018 21:09:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 498FCD63C4 for ; Wed, 17 Jan 2018 21:09:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.711 X-Spam-Level: X-Spam-Status: No, score=-100.711 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id sQF-lbAzokc6 for ; Wed, 17 Jan 2018 21:09:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 7BC065F3DF for ; Wed, 17 Jan 2018 21:09:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B1496E2572 for ; Wed, 17 Jan 2018 21:09:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6F4B7212FF for ; Wed, 17 Jan 2018 21:09:00 +0000 (UTC) Date: Wed, 17 Jan 2018 21:09:00 +0000 (UTC) From: "Galak (JIRA)" To: commits@airflow.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (AIRFLOW-2010) Make HttpHook inner connection pool configurable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AIRFLOW-2010?page=3Dcom.atlass= ian.jira.plugin.system.issuetabpanels:all-tabpanel ] Galak updated AIRFLOW-2010: --------------------------- Description:=20 HttpHook is using request module to perform http/https calls. but it is hid= den inside implementation. Therefore, it is not possible to choose any valu= e for _pool_connections_ or=C2=A0 _pool_maxsize_ parameters, defaulting to = 10. (see [request module documentation|http://docs.python-requests.org/en/l= atest/api/#lower-lower-level-classes]) _{{requests.adapters.HTTPAdapter}}_ parameters could probably be passed thr= ough Airflow Connection extra parameters ? As a consequence, calling a REST API concurrently (using [ThreadPoolExecuto= r|https://docs.python.org/3/library/concurrent.futures.html#threadpoolexecu= tor]) is limited to 10 workers maximim. Each additional worker is stopped w= ith the following warning: {quote} {{\{connectionpool.py\} WARNING - Connection pool is full, discarding conne= ction: my.api.example.org}} {quote} See [this question on stackoverflow|https://stackoverflow.com/questions/236= 32794/in-requests-library-how-can-i-avoid-httpconnectionpool-is-full-discar= ding-con] about Http connexion pools configuration was: HttpHook is using request module to perform http/https calls. but it is hid= den inside implementation. Therefore, it is not possible to choose any valu= e for _pool_connections_ or=C2=A0 _pool_maxsize_ parameters, defaulting to = 10. (see [request module documentation|http://docs.python-requests.org/en/l= atest/api/#lower-lower-level-classes]) _{{requests.adapters.HTTPAdapter}}_ parameters could probably be passed thr= ough Airflow Connection extra parameters ? As a consequence, calling a REST API concurrently (using [ThreadPoolExecuto= r|https://docs.python.org/3/library/concurrent.futures.html#threadpoolexecu= tor]) is limited to 10 workers maximim. Each additional worker is stopped w= ith the following warning: {quote}{{ Unknown macro: \{connectionpool.py} WARNING - Connection pool is full, discarding connection: my.api.example.or= g}} {quote} See [this question on stackoverflow|https://stackoverflow.com/questions/236= 32794/in-requests-library-how-can-i-avoid-httpconnectionpool-is-full-discar= ding-con] about Http connexion pools configuration > Make HttpHook inner connection pool configurable > ------------------------------------------------ > > Key: AIRFLOW-2010 > URL: https://issues.apache.org/jira/browse/AIRFLOW-2010 > Project: Apache Airflow > Issue Type: Improvement > Components: hooks > Affects Versions: 1.8.0 > Reporter: Galak > Priority: Major > > HttpHook is using request module to perform http/https calls. but it is h= idden inside implementation. Therefore, it is not possible to choose any va= lue for _pool_connections_ or=C2=A0 _pool_maxsize_ parameters, defaulting t= o 10. (see [request module documentation|http://docs.python-requests.org/en= /latest/api/#lower-lower-level-classes]) > _{{requests.adapters.HTTPAdapter}}_ parameters could probably be passed t= hrough Airflow Connection extra parameters ? > As a consequence, calling a REST API concurrently (using [ThreadPoolExecu= tor|https://docs.python.org/3/library/concurrent.futures.html#threadpoolexe= cutor]) is limited to 10 workers maximim. Each additional worker is stopped= with the following warning: > {quote} > {{\{connectionpool.py\} WARNING - Connection pool is full, discarding con= nection: my.api.example.org}} > {quote} > See [this question on stackoverflow|https://stackoverflow.com/questions/2= 3632794/in-requests-library-how-can-i-avoid-httpconnectionpool-is-full-disc= arding-con] about Http connexion pools configuration -- This message was sent by Atlassian JIRA (v7.6.3#76005)