airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (AIRFLOW-1887) Misleading variable name in AwsHook for the endpoint URL
Date Thu, 07 Dec 2017 13:55:00 GMT


ASF subversion and git services commented on AIRFLOW-1887:

Commit 9ad6d1202d0466d67b920ce8b316fd0e7b68ed88 in incubator-airflow's branch refs/heads/master
from [~villasv]
[;h=9ad6d12 ]

[AIRFLOW-1887] Renamed endpoint url variable

s3_endpoint_url is a legacy name from when AwsHook
was only used to
connect to S3. The endpoint_url is more general
and what is effectively
used elsewhere for this piece of information.

Closes #2848 from villasv/AIRFLOW-1887

> Misleading variable name in AwsHook for the endpoint URL
> --------------------------------------------------------
>                 Key: AIRFLOW-1887
>                 URL:
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: hooks
>            Reporter: Victor Villas Bôas Chaves
>            Assignee: Victor Villas Bôas Chaves
>            Priority: Trivial
>             Fix For: 1.9.1
> The variable `s3_endpoint_url` has this name for legacy reasons (when the hook dealt
only with S3 connections), but actually represents the endpoint URL for whatever AWS resource
the connection credentials must refer to.

This message was sent by Atlassian JIRA

View raw message