airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Bender (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-1875) Front page UI breaks on second page or past 25 entries
Date Sat, 09 Dec 2017 04:21:02 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284576#comment-16284576
] 

Jonathan Bender commented on AIRFLOW-1875:
------------------------------------------

I'm seeing this issue too. A bit surprised since it seems like pagination isn't on the 1.8.2
branch? I see the commit here: https://github.com/apache/incubator-airflow/commit/b6d2e0a46978e93e16576604624f57d1388814f2

But not here: https://github.com/apache/incubator-airflow/blob/1.8.2/airflow/www/templates/airflow/dags.html

In any case the issue seems to be that the server renders dag_ids_in_page rather than the
full set of dags:
https://github.com/apache/incubator-airflow/blob/b6d2e0a46978e93e16576604624f57d1388814f2/airflow/www/templates/airflow/dags.html#L66

The SVG elements are rendered in this loop: https://github.com/apache/incubator-airflow/blob/b6d2e0a46978e93e16576604624f57d1388814f2/airflow/www/templates/airflow/dags.html#L116

So when the D3.json hooks which render these status run, they can't select the appropriate
SVG element (since it won't be rendered until the user clicks the next tab: https://github.com/apache/incubator-airflow/blob/b6d2e0a46978e93e16576604624f57d1388814f2/airflow/www/templates/airflow/dags.html#L396

Not much of a front-end dev so would be best left to somebody else :) maybe I'll take a crack
though.

> Front page UI breaks on second page or past 25 entries
> ------------------------------------------------------
>
>                 Key: AIRFLOW-1875
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-1875
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: ui
>    Affects Versions: 1.8.2
>            Reporter: Alan Cruickshank
>            Priority: Minor
>              Labels: ui
>         Attachments: Capture-Normal1.PNG, Capture-SecondPage.PNG, Capture-ViewMore.PNG
>
>
> On the main DAGs frontpage (`/admin/`), the normal styling for DAGs fails past the first
page, or if you select to view more than 25, then for those further DAGs.
> The on/off switch just shows as a checkbox rather than the normal styling and the traffic
light icons don't show. Otherwise the UI is normal.
> *Normal styling (top of first page):*
> !Capture-SecondPage.PNG!
> *Broken styling (top of second page):*
> !Capture-SecondPage.PNG!
> *Also broken styling* (this time first page, showing the same two DAGs as before, but
now with "show 50 entries" rather than the default "show 25 entries":
> !Capture-ViewMore.PNG!
> Happy to assist in solving (submitting PR etc...) but I don't quite know where to start
and I'm hoping based on the pattern of failure that someone knows exactly what might be causing
this.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message