Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@airflow.incubator.apache.org
Date: Mon, 13 Nov 2017 15:56:00 +0000 (UTC)
From: "ASF subversion and git services (JIRA)" <jira@apache.org>
To: commits@airflow.incubator.apache.org
Message-ID: <JIRA.13117919.1510576163000.222257.1510588560082@Atlassian.JIRA>
In-Reply-To: <JIRA.13117919.1510576163000@Atlassian.JIRA>
References: <JIRA.13117919.1510576163000@Atlassian.JIRA> <JIRA.13117919.1510576163158@jira-lw-us.apache.org>
Subject: [jira] [Commented] (AIRFLOW-1813) SSH Operator errors on commands
 with no output
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 13 Nov 2017 15:56:04 -0000


    [ https://issues.apache.org/jira/browse/AIRFLOW-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16249761#comment-16249761 ] 

ASF subversion and git services commented on AIRFLOW-1813:
----------------------------------------------------------

Commit fab727d34edfbd9b96c088ae5f8f538f4f74a114 in incubator-airflow's branch refs/heads/v1-9-test from [~RJKeevil]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=fab727d ]

[AIRFLOW-1813] Bug SSH Operator empty buffer

The SSH Operator will throw an empty "SSH operator
error" when running
commands that do not immediately log something to
the terminal. This is
due to a call to stdout.channel.recv when the
channel currently has a
0-size buffer, either because the command has not
yet logged anything,
or never will (e.g. sleep 5)

Make code PEP8 compliant

Closes #2785 from RJKeevil/fix-ssh-operator-no-
terminal-output

(cherry picked from commit d4d8eb932657f4d1eccfaa8bb1d12933535fae94)
Signed-off-by: Bolke de Bruin <bolke@xs4all.nl>


> SSH Operator errors on commands with no output
> ----------------------------------------------
>
>                 Key: AIRFLOW-1813
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-1813
>             Project: Apache Airflow
>          Issue Type: Bug
>            Reporter: Rob Keevil
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The SSH Operator will throw an empty "SSH operator error" when running commands that do not immediately log something to the terminal.  This is due to a call to stdout.channel.recv when the channel currently has a 0-size buffer, either because the command has not yet logged anything, or never will (e.g. sleep 5).  A simple check of the buffer size before reading will fix this issue, will link a PR shortly


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)