Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DE8EA200D43 for ; Tue, 21 Nov 2017 17:02:09 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id DD53B160BFC; Tue, 21 Nov 2017 16:02:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 33207160BED for ; Tue, 21 Nov 2017 17:02:09 +0100 (CET) Received: (qmail 24183 invoked by uid 500); 21 Nov 2017 16:02:08 -0000 Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.incubator.apache.org Delivered-To: mailing list commits@airflow.incubator.apache.org Received: (qmail 24174 invoked by uid 99); 21 Nov 2017 16:02:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Nov 2017 16:02:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id A9D041A249C for ; Tue, 21 Nov 2017 16:02:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id FXRG6qQXvGu1 for ; Tue, 21 Nov 2017 16:02:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 88C2C61192 for ; Tue, 21 Nov 2017 16:02:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 73CBFE25A5 for ; Tue, 21 Nov 2017 16:02:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id D78CF255B7 for ; Tue, 21 Nov 2017 16:02:00 +0000 (UTC) Date: Tue, 21 Nov 2017 16:02:00 +0000 (UTC) From: "Ash Berlin-Taylor (JIRA)" To: commits@airflow.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AIRFLOW-843) Store task exceptions in context MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 21 Nov 2017 16:02:10 -0000 [ https://issues.apache.org/jira/browse/AIRFLOW-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260949#comment-16260949 ] Ash Berlin-Taylor commented on AIRFLOW-843: ------------------------------------------- I think 1. is a "softer" approach that will mean existing on failure hooks in people's code bases wont suddenly error (due to signature mismatch) But we can go with 2. so long as it's mentioned in updating.md > Store task exceptions in context > -------------------------------- > > Key: AIRFLOW-843 > URL: https://issues.apache.org/jira/browse/AIRFLOW-843 > Project: Apache Airflow > Issue Type: Improvement > Reporter: Scott Kruger > Priority: Minor > > If a task encounters an exception during execution, it should store the exception on the execution context so that other methods (namely `on_failure_callback` can access it. This would help with custom error integrations, e.g. Sentry. -- This message was sent by Atlassian JIRA (v6.4.14#64029)